[was] addition to ipfw (read vlans from bridge)..

Julian Elischer julian at elischer.org
Sat Dec 30 16:53:26 PST 2006


Yar Tikhiy wrote:


> However, I have one question regarding "etype", please see below.
> 
>> Index: netinet/ip_fw2.c

>> +	/*
>> +	 * if we have an ether header,
>> +	 */
>> +	if (args->eh)
>> +		etype = (ntohs(args->eh->ether_type)) == ETHERTYPE_VLAN;
> 
> And here we assign a boolean value to etype.  Is it intended?
> Looks like a error to me.  Apparently it should read:
> 
> 		etype = ntohs(args->eh->ether_type);
> 

good catch!


More information about the freebsd-net mailing list