Code nit questions...
JINMEI Tatuya /神明達哉
jinmei at isl.rdc.toshiba.co.jp
Fri May 20 14:49:05 PDT 2005
>>>>> On Tue, 17 May 2005 11:05:10 -0700,
>>>>> gnn at freebsd.org said:
>> > *) Insert proper return value checking.
>>
>> in6_embedscope() should not fail in this context (so we could even
>> panic if it does), but you probably want to be very proactive by
>> eliminating as many (hidden) assumptions as possible. If so, please
>> go ahead with the change, but then I'd rather check the return value
>> of in6_recoverscope() as well.
The latest KAME snap does not use ip6_embedscope() or
in6_recoverscope() in the corresponding part. So, please simply go
ahead with whatever change you want to make.
BTW: you do not necessarily have to wait for the KAME snap before
committing changes to the FreeBSD repository, particularly for trivial
fixes like this one. Of course, we always appreciate a prior notice
and solicitation of comments.
JINMEI, Tatuya
Communication Platform Lab.
Corporate R&D Center, Toshiba Corp.
jinmei at isl.rdc.toshiba.co.jp
More information about the freebsd-net
mailing list