Global (non _KERNEL) place for sockaddr_union?

[Max Laier]

On Monday 20 September 2004 02:50, Max Laier wrote:
> Hi,
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/71836 is the symptom. Now I
> am looking for a clean solution to it. What is needed is an include file
> that defines union sockaddr_union in a way that is useable from kernel and
> userland. Historically it seems that this union first apeared in context of
> ipsec within the kernel. pf has adopted it, but uses it in the userland as
> well. I am sure that it can be usefull in a lot of places that have to deal
> with/store different address formats.
>
> My question now is, what would be a good place to define this? Are there
> any fromal standarts that might define it already? (Couldn't find anything)
> Is there anything else that I must consider?
>
> At some point I though netinet/in.h might be a good place, but that'd
> require inclusion of sys/socket.h, which certainly is not a good solution.
>
> Opinions? Ideas?

As no real solution has come up and we couldn't agree what to do with it 
either, I'll resort to an easy hack: 
 http://people.freebsd.org/~mlaier/sockaddr_union.fix.diff

This will fix the issue and not create new problems. With the small exception 
for userland programs that try to include <netipsec/keydb.h> before 
<net/pfvar.h> and make use of sockaddr_union. Those programs do not exist, 
however, and have been broken before.

Any objections? [ I know it's ugly already. ]

-- 
/"\  Best regards,                      | mlaier at freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier at EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-net/attachments/20040923/badab561/attachment.bin