bridge callbacks in if_ed.c?

Gleb Smirnoff glebius at freebsd.org
Sun Sep 5 23:33:16 PDT 2004


On Sun, Sep 05, 2004 at 10:29:54PM -0700, Luigi Rizzo wrote:
L> > L> I'd rather not apply the patch unless you can show that
L> > L> the current code leads to incorrect behaviour.
L> > 
L> > I suspect that packets dropped by bridge_in() called from if_ed will
L> > not be captured by bpf(4). This is incorrect.
L> 
L> if you read the code you see that the bpf behaviour is
L> as it should be, and your suspect is unfounded.
L> 
L> -       if (!ifp->if_bpf && BDG_ACTIVE( (ifp) ) ) {

You are right, sorry.

But the packets dropped by bridge will not enter lower hook of
ng_ether(4), like they do in case of other interfaces.

L> (my summary and pov on the discussion in a separate email)

Actually, I'm working on better interaction of ng_ether and bridge,
and this hack in if_ed is on the way. And this "will se the light"
quite soon.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE


More information about the freebsd-net mailing list