Initial review request for IPv6 Fast Forwarding and IP6STEALTH

[James]

On Sun, Nov 21, 2004 at 09:12:10AM -0800, gnn at freebsd.org wrote:
> Hi James,
> 
> 	A few comments for you:

Hi George,

Thanks for your good comments and catch on the line 223! I'll integreate 
the fixes soon for the final draft.

-J

> 
> Issues found:
>     ip6_forward_rt is a global value that is used without locking
>     ASSERTS still include the old name apc_inet6_fastfwd
>     Stats are updated directly but I don't think we lock those yet.
>     Don't define M2MMAX in line, put it outside with a comment.
>     If the mbuf is already freed then how can we safely use m->m_pkthdr.rcvif? at line 223
>     Improve the indenting in the commented case at line 298.  I understand the idea, and it's good, but it's a bit confusing to read.
>     Remove #if code at 553 which is specific to the APC product.
> 
> Later,
> George

-- 
James Jun                                            TowardEX Technologies, Inc.
Technical Lead                      Boston IPv4/IPv6 Web Hosting, Colocation and
james at towardex.com            Network design/consulting & configuration services
cell: 1(978)-394-2867           web: http://www.towardex.com , noc: www.twdx.net