Nodes having common properties. Was: kern/63864: [patch] new control message for ng_iface(4) - getifindex

[Gleb Smirnoff]

On Fri, Mar 19, 2004 at 02:24:47PM +0100, Harti Brandt wrote:
H> From the point of code duplication and extendibility both approaches are
H> equivalent. In the second case you have the same three lines in the rcvmsg
H> function of every node that supports a given familiy (this is reduceable
H> to 1 line by defining appropriate macros), in the first one you have the
H> same line in every constructor. Perhaps I made not clear that the message
H> handling function for the familiy is not in the node's code nor in the
H> netgraph base code, but in a family file (in both cases) and module.

I understand, now. If ng_process_family_xxx_msg() is out of node, than
you are right - approeaches are equivalent.

H> But I have no strong opinion: either way does it as long as it allows
H> multiple interfaces to a given node.

OK, let's wait for reply from someone in Cc: 
:)

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE