PPPoE buglet...

[Julian Elischer]

The RFC is al that matters (except for
the compatibility code for idiot suppliers that use the wrong
ethertype.)

Is there a 110 or 1001 nearby that I may have read in error in the spec?


On Wed, 17 Mar 2004, David Malone wrote:

> I spent a while trying to get PPPoE going through a Netopia smart
> modem last night. To cut a long story short, the values for
> PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least
> when compared with tcpdump, linux and the RFC). We have:
> 
> #if BYTE_ORDER == BIG_ENDIAN
> #define PTT_RELAY_SID   (0x0106)
> #else
> #define PTT_RELAY_SID   (0x0601)
> #endif
> 
> but we should have:
> 
> #if BYTE_ORDER == BIG_ENDIAN
> #define PTT_RELAY_SID   (0x0110)
> #else
> #define PTT_RELAY_SID   (0x1001)
> #endif
> 
> Anyone object to my fixing it? The only thing I can think of that
> it might break would be people using ng_pppoe as a PPPoE relay with
> only ng_pppoe PPPoE clients.
> 
> 	David.
> _______________________________________________
> freebsd-net at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe at freebsd.org"
>