HEADSUP! netgraph Metadata changing.

[Ruslan Ermilov]

On Mon, Jun 07, 2004 at 11:44:10AM +0400, Gleb Smirnoff wrote:
> On Mon, Jun 07, 2004 at 10:38:12AM +0300, Ruslan Ermilov wrote:
> R> On Mon, Jun 07, 2004 at 11:17:01AM +0400, Gleb Smirnoff wrote:
> R> > On Sun, Jun 06, 2004 at 06:35:51PM -0700, Julian Elischer wrote:
> R> > J> In addition the ng_ksocket node adds info into metadata and I suspect
> R> > J> there are people using that.
> R> > 
> R> > Since ng_ksocket tags packets for itself only, we can safely change it.
> R> > 
> R> I use this feature in one proprietary module (need to send/recevive
> R> UDP datagrams to/from different destinations).
> 
> Does your module reads/writes meta?
> 
It does, in its "rcvdata" method:

	NG_FREE_META(meta);
	len = sizeof(*meta) + sizeof(*mhead) + sizeof(*sin);
	MALLOC(meta, meta_p, len, M_NETGRAPH,
	    M_NOWAIT | M_ZERO);
	if (meta == NULL) {
		NG_FREE_M(m);
		return (ENOMEM);
	}
	...

Yes, the change will break it.  No, I'm not opposed to a change.
I was just commenting on the "for itself" bit, it's not true.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-net/attachments/20040607/2d431666/attachment.bin