PPPoE problem: "Too many LQR packets lost"

[Stephen McKay]

On Saturday, 24th July 2004, Mike Tancsa wrote:

>On Sat, 24 Jul 2004 12:47:26 +1000, in sentex.lists.freebsd.net you
>wrote:
>
>>I found Mike Tancsa's patch but didn't like it.  I rolled my own, which
>>seems to be working so far.  It works by switching from LQR to simple
>>echo requests when LQR times out.
>
>I feel so unliked ;-)

:-)

>Seriously though, mine was a very ugly hack to
>get things working again for me.   Most of the DSL aggregators here
>are Juniper ERXes which do not play nice with FreeBSD's PPPoE.

I think I would have just taken your hack if it had been in lqr_Setup()
where hdlc.lqm.method is initially set.  As it was I was in a funny mood
and wanted to write my own hack. :-)

>>(This is a patch against ppp in FreeBSD 4.8.  I haven't tried the ppp in
>>-current yet as -current is still a wild and woolly place that scares me.)
>
>I think Brian re worked the LQR portion at least from looking at the
>commit messages

If I'm looking at the same stuff as you, he's reworked the LQR code to
be more accurate with byte counts and such.  I don't see any changes that
address our "LQR fails completely" problems.

Stephen.