TEST/REVIEW ng_ether/ng_pppoe/ppp

[Bjoern A. Zeeb]

On Sun, 15 Feb 2004, Julian Elischer wrote:

Hi,

first thanks for your feedback.

> this comment and the code disagree....
> +	/* If "promisc" hook not connected, let packet continue */
> +	if (priv->lower == NULL || priv->lowerType!=LOWER_TYPE_PROMISC) {
> +		m_freem(m);
> +		return;
> +	}
>
>
> if not connected.. discarded....

I will update this and also change the comment for the orphan hook.


> In the documentation:
> +written to the hook. The interface has to be put into promiscuous before
> +by using p.ex.
> +.Dv NGM_ETHER_SET_PROMISC .
> +Normal incoming traffic is unaffected.
>
> what is the "p.ex" ?

I should have written e.g. or even better for example.
p.ex. is per exemplum (latin).


> you should  make an attempt to contact brian

will do so. aah he's on Cc: already.


Thanks again.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
56 69 73 69 74				http://www.zabbadoz.net/