RFC: if_clone overhaul

Brooks Davis brooks at one-eyed-alien.net
Wed Apr 21 22:39:21 PDT 2004


On Tue, Apr 20, 2004 at 09:24:53PM -0700, Brooks Davis wrote:
> Please test/review the following patch to the network interface cloneing
> code.  This code is a major overhaul of the cloning infrastructure.

Repeat after me, always test your "trivial" last minute changes.  You
need to apply the following patch after applying the previous patch if
you want the code to compile.

-- Brooks

Change 51546 by brooks at brooks_minya on 2004/04/21 22:29:18

	Unreorder struct if_clone so initalizer works.  Should probably
	switch to C99 sparc initalizers..

Affected files ...

.. //depot/user/brooks/xname/sys/net/if_clone.h#11 edit

Differences ...

==== //depot/user/brooks/xname/sys/net/if_clone.h#11 (text+ko) ====

@@ -61,14 +61,15 @@
 					/*     via ifc_(alloc|free)_unit(). */
 	int ifc_bmlen;			/* (c) Bitmap length. */
 	void *ifc_data;			/* (*) Data for ifc_* functions. */
-	long ifc_refcnt;		/* (i) Refrence count. */
-	struct mtx ifc_mtx;		/* Muted to protect members. */
 
 	/* (c) Driver specific cloning functions.  Called with no locks held. */
 	void	(*ifc_attach)(struct if_clone *);
 	int	(*ifc_match)(struct if_clone *, const char *);
 	int	(*ifc_create)(struct if_clone *, char *, size_t);
 	int	(*ifc_destroy)(struct if_clone *, struct ifnet *);
+
+	long ifc_refcnt;		/* (i) Refrence count. */
+	struct mtx ifc_mtx;		/* Muted to protect members. */
 };
 
 void	if_clone_init(void);


-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-net/attachments/20040421/4f1cbd26/attachment.bin


More information about the freebsd-net mailing list