[Bug 239509] multimedia/ffmpeg: Fix build dependencies and minor clean-up

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239509

--- Comment #3 from Jan Beich <jbeich at FreeBSD.org> ---
(In reply to daniel.engberg.lists from comment #2)
> what do you mean by GNU as elsewhere?

When building on aarch64 without devel/binutils:

  ===>  Configuring for ffmpeg-4.2,1
  GNU assembler not found, install/update gas-preprocessor

which is under the following conditional in configure:

  if enabled_any arm aarch64 || enabled_all ppc altivec && enabled asm; then

Do you see x86 there?

> Yes, -O2 it's purely a cosmetic/readability fix
> but as that considered bad pratice?

Cosmetic changes unnecessarily complicate maintenance. .include
<bsd.port.options.mk> is also unnecessary given -O2 comes from sys.mk, not
bsd.port.mk. And ${CFLAGS:S/-O2//g} maybe better spelled as ${CFLAGS:N-O*}.

-- 
You are receiving this mail because:
You are the assignee for the bug.