[Bug 226926] [PATCH] Tools/scripts/bump-revision.sh lacks a safety belt

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226926

Matthias Andree <mandree at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mandree at FreeBSD.org

--- Comment #1 from Matthias Andree <mandree at FreeBSD.org> ---
Since Gerald pointed me to the PR, I take the liberty to add some unsolicited
feedback, I hope he does not mind.

- personally, I prefer var="$(some command)" over the backtick notation,
because it resolves doubts about quoting

- I suggest to use "pkg version -t pre post" as a comparison, rather than [ ...
-le ... ] (aka. test ... -le ...) because I *believe* (without testing) that
the existing version would not support lexicographical wraps when numbers get
longer, for instance, when bumping from PORTREVISION=9 to ...=10 because 10
sorts before 9 if you sort them as string.

-- 
You are receiving this mail because:
You are the assignee for the bug.