mixer_info modify_counter

Ali Abdallah aliovx at gmail.com
Sun Jul 22 18:09:05 UTC 2018


Hello,

Any reason why the modify_counter bit of mixer_info is not incremented when
the mixer gets changed?

>From  sys/dev/sound/pcm/mixer.c:70
/**
  * Counter is incremented when applications change any of this
  * mixer's controls.  A change in value indicates that persistent
  * mixer applications should update their displays.
  */

But reading the code, it is clear that this is not the case, and the
counter remains 0. It is enough to call m->modify_counter++ in mixer_set on
line 327 for example to make persistent mixer applications work correctly.
Currently they have to poll for all mixer controls, even if no changes were
made to the mixer.

Best,
Ali


More information about the freebsd-multimedia mailing list