maintainer-feedback requested: [Bug 213999] multimedia/livestreamer: Unnecessary requests1 dependency conflic with other ports that depend on www/py-requests

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Nov 2 08:45:55 UTC 2016


Kubilay Kocak <koobs at FreeBSD.org> has asked multimedia at FreeBSD.org for
maintainer-feedback:
Bug 213999: multimedia/livestreamer: Unnecessary requests1 dependency conflic
with other ports that depend on www/py-requests
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213999



--- Comment #2 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thank you for the patch.

Could you please run livestreamers test suite (with `python-x.y setup.py test`
in WKRSRC after extracting) to confirm that tests pass with requests 2.x.

I also note in setup.py, the following, which is a good indication that
requests 2.x support is OK:

# requests 2.0 does not work correctly on Python <2.6.3
if (version_info[0] == 2 and version_info[1] == 6 and version_info[2] < 3):
    deps.append("requests>=1.0,<2.0")
else:
deps.append("requests>=1.0,<3.0")

For reference, all ports depending on www/py-requests in the past were changed
to requests1 [1][2] when py-requests was updated to 2.x, allowing individual
port maintainers to make the change to the later version themselves.

[1] https://svnweb.freebsd.org/ports?view=revision&revision=341384
[2] https://svnweb.freebsd.org/ports?view=revision&revision=341385


More information about the freebsd-multimedia mailing list