Is this a bug? (in /usr/src/sys/dev/bktr/bktr_os.c )

[Carlos A. M. dos Santos]

On Thu, Sep 4, 2008 at 9:59 PM, Fritz Katz <frtzkatz at yahoo.com> wrote:
> In FreeBSD-7.0, /usr/src/sys/dev/bktr/bktr_os.c, line 469:
>
> http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70#L469
> __________
>
> fail:
>  if (bktr->res_irq)
>     bus_release_resource(dev, SYS_RES_IRQ, bktr->irq_rid, bktr->res_irq);
>  if (bktr->res_mem)
>     bus_release_resource(dev, SYS_RES_IRQ, bktr->mem_rid, bktr->res_mem);
>  return error;
> __________
>
> Shouldn't the type field for the second bus_release_resource be SYS_RES_MEMORY?  Would it cause a kernel panic if it were ever hit?  If it is a bug, it's probably been there for years.

For sure it is a bug, since it is not in accordance with

http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70;im=excerpts#L347

-- 
cd /usr/ports/sysutils/life
make clean