uaudio patch, configurable buffer size

[Pyun YongHyeon]

On Sun, Mar 06, 2005 at 04:28:11PM +0100, Alexander Leidinger wrote:
 > On Sat, 5 Mar 2005 17:40:05 -0500
 > Mathew Kanner <mat at cnd.mcgill.ca> wrote:
 > 
 > > Hi All,
 > > 	I couldn't use my usb device because the default buffer size
 > > (16*1024 bytes) was too much to be allocated (dma changes that
 > > happened a while ago).  The following is a patch to make it a tunable:
 > > 
 > > http://www.cnd.mcgill.ca/~mat/uaudio-HEAD-buffersize-tunable.diff.gz
 > 
 > There's an open PR about it. It changes the buffer size. AFAIR it also
 > talks about changing the value of a parameter to a busdma call instead.
 > I've patched the busdma call and now the device is detected here (but I
 > don't hear any output...).
 > 
 > I think you should add another set of validation code: The buffer size
 > is divided by 2 in the code, so I think it should at least print a
 > warning if "buffsize % 2 != 0".
 > 

AFAIK no. The buffer size should be power of 2.
See pcm_getbuffersize() in sound.c.
-- 
Regards,
Pyun YongHyeon
http://www.kr.freebsd.org/~yongari	|	yongari at freebsd.org