Trouble with APM suspend in 5.3-R

[M. Warner Losh]

In message: <41F02CE1.5090207 at acm.org>
            Dave Walton <dwalton at acm.org> writes:
: Andrew Belashov wrote:
: > Dave Walton wrote:
: > 
: >> I've been unable to get APM suspend/resume to work with 5.3-R on my 
: >> Thinkpad 770Z.  As released, 'apm -z' causes a lockup (it worked fine 
: >> in 4.x).  Revision 1.233 of ata-all.c fixes that, and 'apm -z' now 
: >> causes the system to properly suspend to disk, as it had before.  
: >> However, when the system resumes, it spits out three errors regarding 
: >> pir0, then panics.  This happens with or without your patch applied to 
: >> ata-all.c.
: >>
: > 
: > Try attached patch as workaround.
: 
: A good effort!  That is precisely the error I saw.  Hopefully, that 
: removed call to pci_pir_biosroute() doesn't do anything important.
: 
: Unfortunately, this had no effect at all on the panic.  Please see my 
: next reply to Gleb Smirnoff for details on the panic.  Perhaps it will 
: mean something to you.

Chances are the right fix is to try the route, but ignore errors...
I've found problems like this in the pci code in the past and worked
around it this way (becaues it breaks some machines if you don't even
try).

Warner