Trouble with APM suspend in 5.3-R

[Dave Walton]

Andrew Belashov wrote:
> Dave Walton wrote:
> 
>> I've been unable to get APM suspend/resume to work with 5.3-R on my 
>> Thinkpad 770Z.  As released, 'apm -z' causes a lockup (it worked fine 
>> in 4.x).  Revision 1.233 of ata-all.c fixes that, and 'apm -z' now 
>> causes the system to properly suspend to disk, as it had before.  
>> However, when the system resumes, it spits out three errors regarding 
>> pir0, then panics.  This happens with or without your patch applied to 
>> ata-all.c.
>>
> 
> Try attached patch as workaround.

A good effort!  That is precisely the error I saw.  Hopefully, that 
removed call to pci_pir_biosroute() doesn't do anything important.

Unfortunately, this had no effect at all on the panic.  Please see my 
next reply to Gleb Smirnoff for details on the panic.  Perhaps it will 
mean something to you.

Thanks,
Dave


> ------------------------------------------------------------------------
> 
> --- sys/i386/pci/pci_pir.c.orig	Fri Jul 30 19:51:30 2004
> +++ sys/i386/pci/pci_pir.c	Sun Nov 14 21:47:33 2004
> @@ -717,8 +717,12 @@ pir_resume(device_t dev)
>  			    "Using %d.%d.INT%c to route link %#x to IRQ %d\n",
>  				    pd.bus, pd.device, pd.pin + 'A',
>  				    pci_link->pl_id, pci_link->pl_irq);
> +#if 0
>  			error = pci_pir_biosroute(pd.bus, pd.device, 0, pd.pin,
>  			    pci_link->pl_irq);
> +#else
> +			error = 0;
> +#endif
>  			if (error)
>  				device_printf(dev,
>  			    "ROUTE_INTERRUPT on resume for link %#x failed.\n",