Please test fix for bad Vcc errors

M. Warner Losh imp at bsdimp.com
Wed Oct 6 08:40:55 PDT 2004


In message: <1097067591.2282.2.camel at localhost>
            Vladimir Grebenschikov <vova at fbsd.ru> writes:
: В ср, 06/10/2004 в 00:43 -0600, M. Warner Losh пишет:
: 
: Hi
: 
: > If you have an older laptop that's getting bad Vcc errors, please test
: > this patch.  There's a number of laptops with resource issues.  If you
: > are using ACPI, this won't change anything (I have a separate patch
: > for that).
: 
: How about separate patch for ACPI-based laptops ?

OK.  Here's what I think will fix acpi based ones.  I've already
committed it to current, but will be interested in what people find.

Warner

-------------- next part --------------
Index: acpi_pcib_acpi.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_acpi.c,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- acpi_pcib_acpi.c	22 Sep 2004 15:46:16 -0000	1.40
+++ acpi_pcib_acpi.c	6 Oct 2004 07:26:52 -0000	1.41
@@ -305,16 +305,16 @@
     u_long start, u_long end, u_long count, u_int flags)
 {
     /*
-     * If no memory preference is given, use upper 2GB slot most
+     * If no memory preference is given, use upper 32MB slot most
      * bioses use for their memory window.  Typically other bridges
      * before us get in the way to assert their preferences on memory.
      * Hardcoding like this sucks, so a more MD/MI way needs to be
      * found to do it.  This is typically only used on older laptops
-     * that don't have pci busses behind pci bridge, so assuming < 2GB
+     * that don't have pci busses behind pci bridge, so assuming > 32MB
      * is liekly OK.
      */
     if (type == SYS_RES_MEMORY && start == 0UL && end == ~0UL)
-	start = 0x80000000;
+	start = 0xfe000000;
     return (bus_generic_alloc_resource(dev, child, type, rid, start, end,
 	count, flags));
 }


More information about the freebsd-mobile mailing list