pccbb pccard rman - Something is very wrong somewhere

[Carlos Velasco]

On 09/04/2004 at 2:34 Carlos Velasco wrote:

>However it does not work, it reads CIS but card doesn't work. I think it's
>because further resources (pccard0: ccr_res == 88002000-880023ff,
>base=ff80) need 64k alignment too for card to work.

Warner,

My laptop has <TI1225 PCI-CardBus Bridge>
I have been googling and have seen other problems related to this cardbus
in freebsd.
I think possible this "alignment" problem is related to this specific
cardbus chipset. I will review the pccbb code but I'm not an expert into
this.

On the other hand, could someone commit this for rman? It's a clear
mistake:

diff -ur sys/kern/subr_rman.c sysnew/kern/subr_rman.c
--- sys/kern/subr_rman.c	Wed Jun 11 00:56:57 2003
+++ sysnew/kern/subr_rman.c	Tue Apr  6 11:41:23 2004
@@ -234,7 +234,7 @@
 				rstart += bound - (rstart & ~bmask);
 		} while ((rstart & amask) != 0 && rstart < end &&
 		    rstart < s->r_end);
-		rend = ulmin(s->r_end, ulmax(rstart + count, end));
+		rend = ulmin(s->r_end, ulmax(rstart + count - 1, end));
 		if (rstart > rend) {
 			DPRINTF(("adjusted start exceeds end\n"));
 			continue;




Regards,
Carlos Velasco