patch for toshiba acpi

[edscott wilson garcia]

On Wed, 2003-09-10 at 08:53, Hiroyuki Aizu wrote:
> Hi.
> 
> Little bit time passes ...

Hi Hiroyuki,

I've compiled and tested your module on Satellite 2455 and have a few
comments (good, of course).

> 
> On 19 Aug 2003 20:34:25 -0500
> edscott wilson garcia <edscott at imp.mx> wrote:
> > I finally got the lcd brightness control and force-fan to work on a
> > toshiba 2455 on FreeBSD 5.1. If anybody is interested, you can find the
> > patch at http://linux.imp.mx/toshiba/
> 
> 
> I wrote TOSHIBA HCI driver base on ACPI. I was tested on Libretto L5 series. 
> This driver should work with other TOSHIBA.
> And this driver works as loadable module.
> 
> This driver has a remarkable improvement that you can control with Fn+? keys.
> 
> Features
> Fn+Esc Force keep running to fan

Works fine.

> Fn+F2  Same as push sleep button
>        (You should set hw.acpi.sleep_button_state=S3)

Did not test with state S3 because recovery from state S3 on this
toshiba model is bugged (after recovery, if computer enters dpms the
system crashes). This bug has nothing to do with acpi.

> Fn+F5  VGA Output Switch (LCD->CRT->Both->None)

A bug here. With the satellite 2455 the Fn+F5 for changing display mode
already works *without* any acpi. When the toshiba_acpi module is
loaded, it seems that they fight. This is the behaviour:
1=LCD
2=CRT
3=BOTH
4=NONE
5=LCD
Fn+F5+F5: (pressing F5 twice): 1->3->5->1
Fn+F5: 1->4->2->5 (will not cycle)

The behaviour without any acpi is:
Fn+F5: 1->4->5->3->2->1

A boolean hw.acpi.toshiba.output_switch to turn the function off for
toshiba models that do not need VGA Output Switch would be nice.

> Fn+F6  LCD Brightness decrease
> Fn+F7  LCD Brightness increase
> Fn+F8  LCD Backlight on/off

Above three work fine. The Fn+F8 is specially useful :-)

> 
> Of cource, you can control these feature with sysctl.
> 
> # sysctl hw.acpi.toshiba
> hw.acpi.toshiba.force_fan: 0
> hw.acpi.toshiba.video_output: 1
> hw.acpi.toshiba.lcd_brightness_level: 6
> hw.acpi.toshiba.lcd_backlight: 1
> 
> 

If the older patch at http://linux.imp.mx/toshiba has been applied,
precede by

0.0 Reverse the patch application
0.1 cd /usr/src/sys/modules/acpi
0.2 make clean && make && make install

This puts the acpi module back to normal.

> 1. Extract acpi_toshiba.tar.gz at /usr/src/sys
> 2. apply files.diff
> 3. re-compile kernel
> 4. install kernel

Steps 3 and 4 are overkill. You can save time by just:
4. cd /usr/src/sys/modules/acpi_toshiba
5. make && make install

> 5. add  acpi_toshiba_load="YES" to /boot/loader.conf
>    or load acpi_toshiba at boot time.
> 
> Please try this driver and test report welcome.

Excellent work! Would you happen to know if it is possible to
disactivate the touchpad by using acpi and the Fn+F9? 

Thanks for the good work. 

Edscott Wilson Garcia

BTW, I'm putting your patch at http://linux.imp.mx/toshiba so googlers
can find it.

> 
> --
> Hiroyuki Aizu
> 
> ______________________________________________________________________
> _______________________________________________
> freebsd-mobile at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-mobile
> To unsubscribe, send any mail to "freebsd-mobile-unsubscribe at freebsd.org"