[Bug 216831] [PATCH] sys/mips/cavium/octeon_machdep.c: add cavium octeon 'bootoctlinux' boot argument support

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu Mar 16 00:37:12 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216831

--- Comment #13 from Alexander Kabaev <kan at FreeBSD.org> ---
(In reply to Alexander Kabaev from comment #12)

Umm, a question - does argv[0] contain useful value? My userland habits protest
against using argv[0] as command line parameter. 

+       for (i = 0; i < app_desc_ptr->argc; i++) {

Anyway, I am committing a slightly different patch that moves parse_boothowto
back into octeon-specific machdep file. I was the one who requested the code to
be shared, but since your change does not update other existing platform to use
common functions, putting it in MI file defeats the purpose. If and when
someone actually makes the function be used by more than one client, then it
can be moved to MI code.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-mips mailing list