[Bug 216831] [PATCH] sys/mips/cavium/octeon_machdep.c: add cavium octeon 'bootoctlinux' boot argument support

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216831

Juli Mallett <jmallett at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jmallett at FreeBSD.org

--- Comment #7 from Juli Mallett <jmallett at FreeBSD.org> ---
Hey Dave,

A couple of minor thoughts on your patch:

1. Maybe don't assume the starting argument index.  I'm pretty sure you can
pass arguments just fine even if coremask is absent, or am I misremembering? 
It's been awhile since I had to deal with it, honestly.  You could easily
enough do strcmp on the n from strsep to ignore those parameters.
2. If you do want to add boothowto_parse, which is a fine idea in my opinion,
please make the passed parameter const!

Thanks very much for doing this!

-- 
You are receiving this mail because:
You are the assignee for the bug.