svn commit: r225892 - head/sys/mips/mips

[Andrew Duane]

I'm not concerned with the size of the code per se. I'm concerned that some day the code will change and no longer be 16 bytes, but the "16" won't get changed on the other side. I've seen far too many cases of that over the years.

This could be handled by two matching comments, one in each place, or by some form of assert that the difference must be 16, or by computing the difference and using that as the "16".

 ...................................
Andrew Duane
Juniper Networks
o   +1 978 589 0551
m  +1 603-770-7088
aduane at juniper.net

 


> -----Original Message-----
> From: adrian.chadd at gmail.com [mailto:adrian.chadd at gmail.com] On Behalf
> Of Adrian Chadd
> Sent: Sunday, October 09, 2011 7:47 AM
> To: Andrew Duane
> Cc: Jayachandran C.; Warner Losh; Kostik Belousov; Alexander Motin;
> freebsd-mips at freebsd.org
> Subject: Re: svn commit: r225892 - head/sys/mips/mips
> 
> On 5 October 2011 01:49, Andrew Duane <aduane at juniper.net> wrote:
> > An assert, or some other check would work. Could you just add
> "EndWaitSkip - StartWaitSkip" somehow? I just worry that some day it
> won't be 16 bytes any more....
> 
> Well, the linux code is 32 bytes rather than 16.
> 
> And it should be easy to extend the range to 32 bytes instead of 16
> bytes.
> 
> Unfortunately the patch doesn't (yet) work, I'm going to do some more
> in depth testing next week.
> 
> Thanks,
> 
> 
> Adrian