Blatant simple bug in Cavium SDK USB code?

[Patrick Mahan]

On 4/1/11 11:08 AM, Andrew Duane wrote:
> 
> In the routine cvmx_usb_initialize in sys/contrib/octeon-sdk/cvmx-usb.c, I'm pretty sure there's a silly little bug that really BADLY breaks the USB driver for some of us.
> 
> Near the top, after it finds board type and sets the clock type, as part of the structure initialization, there is:
> 
>     memset(usb, 0, sizeof(usb));
> 
> Tell me that is not supposed to be:
> 
>     memset(usb, 0, sizeof(*usb));
> 
> The existing code only zeros 4/8 bytes, instead of the 23KB of the structure.
> 

Ugh... Looks like this is an original bug from Cavium.  No wonder I always
had issues working with the USB in u-boot off of the SDK.

I see this is my 1.9 Cavium SDK.  Not sure if it is on a more recent version.

Patrick