patch: fix and re-enable curthread hash lookup

Kurt Miller lists at intricatesoftware.com
Mon Feb 26 02:49:13 UTC 2007


On Thursday 22 February 2007 6:10 pm, Arne H. Juul wrote:
> I've analyzed the currently disabled code that implements a faster method 
> to find the current (Java) thread object by getting hold of the stack 
> pointer and doing a lookup in a hash table.  This used to fail on thread 
> exit sometimes because the invalidation wasn't done properly; I've also 
> changed some of the parameters for the hash code and upped the size of the 
> hash table so it should be more optimal.
> 
> Finally I've added a "near hit" feature that should make the lookup faster 
> when a thread is crossing back and forth over a stack page boundary; 
> earlier this would always trigger the slow path, but now it compares the 
> current stack pointer with the low and high stack boundaries and gets a 
> hit if the hash table entry still points at the right thread object.
> 
> This patch is still experimental, so if people can take a look at it and 
> tell me about any problems they can spot that would be much appreciated.
> 
>    -  Arne H. J.

Hi,

I tried to apply the diff but all parts were rejected.
Can you send this again in unified format? I don't mind
applying it manually but I only grock unified diffs. :-)

-Kurt


More information about the freebsd-java mailing list