jail: unknown parameter: ip6.addr

[Chris Rees]

[adding rc@, please keep me CCd as I'm not in jail@]

On Thu, 2012-11-08 at 02:27 +0100, Mateusz Guzik wrote:
> On Wed, Nov 07, 2012 at 03:39:26PM -0500, Mike Jakubik wrote:
> > Hello,
> >
> > I just updated a server to latest stable and my jails no longer start,
> > troubleshooting the startup script shows us that the parameter ip6.addr
> > is unknown, this system is compiled without INET6.
> [..]
> > + tail +2 /tmp/jail.PJ5ji3QH/jail.8101
> > jail: unknown parameter: ip6.addr
>
> Try this (lightly tested):
> http://people.freebsd.org/~mjg/patches/rc-jail-ip-arg.diff
>
> Basically the idea is to pass ip4.addr and ip6.addr only when respective
> addresses are specified in configuration.


Since we've had confirmation that the patch works, a much faster way
is to use sh's variable substitution magic, which also means a much
smaller change:

-            ip4.addr=\"${_addrl}\" ip6.addr=\"${_addr6l}\"
${_parameters} command=${_exec_start} > ${_tmp_jail} 2>&1 \
+            ${_addrl:+ip4.addr=\"${_addrl}\"}
${_addr6l:+ip6.addr=\"${_addr6l}\"} ${_parameters}
command=${_exec_start} > ${_tmp_jail} 2>&1 \

I'll get a patch together later

Chris