Breakage on 9

Ed Schouten ed at 80386.nl
Mon May 21 18:08:22 UTC 2012


Hi,

Today I was bitten by the "jail: unknown parameter: allow.nomount"
bug. It seems this bug is at least more than one month old -- on
9-STABLE! Why hasn't the commit that introduced this bug been backed
out? The code worked before. Now it's broken and we're waiting for an
MFC period? Using a Danish (Dutch?) axe, I was able to at least get my
box working again:

Index: lib/libjail/jail.c
===================================================================
--- lib/libjail/jail.c	(revision 235725)
+++ lib/libjail/jail.c	(working copy)
@@ -890,7 +890,7 @@
 			snprintf(jail_errmsg, JAIL_ERRMSGLEN,
 			    "unknown parameter: %s", jp->jp_name);
 			errno = ENOENT;
-			return (-1);
+			return (0);
 		}
 		snprintf(desc.s, sizeof(desc.s), SJPARAM ".%s", nname);
 		free(nname);

-- 
Ed Schouten <ed at 80386.nl>


More information about the freebsd-jail mailing list