misc/174436: [jail] Jails with numbers as names don't work

[Mateusz Guzik]

The following reply was made to PR kern/174436; it has been noted by GNATS.

From: Mateusz Guzik <mjguzik at gmail.com>
To: Robert Schulze <rs at bytecamp.net>
Cc: bug-followup at FreeBSD.org
Subject: Re: misc/174436: [jail] Jails with numbers as names don't work
Date: Tue, 18 Dec 2012 11:18:37 +0100

 On Tue, Dec 18, 2012 at 10:48:18AM +0100, Robert Schulze wrote:
 > Hi,
 > 
 > Am 17.12.2012 22:31, schrieb Mateusz Guzik:
 > >
 > >Can you send me your kernel or put somewhere for download?
 > >
 > >If not, provide output of the following:
 > ># addr2line -e /boot/kernel/kernel 0xffffffff804debff
 > ># addr2line -e /boot/kernel/kernel 0xffffffff804dbef6
 > 
 > # addr2line -e /boot/kernel/kernel 0xffffffff804debff
 > /usr/src/sys/kern/kern_jail.c:1848
 > # addr2line -e /boot/kernel/kernel 0xffffffff804dbef6
 > /usr/src/sys/kern/kern_jail.c:4537
 > 
 > >Also I don't think that '0' has any significance here. Can you change it
 > >to something else and try again? Can you try with different IP?
 > >Preferably 127.0.0.2 on lo0.
 > 
 
 I was reading wrong version of rc.d script. Name is passed with -n switch.
 
 Looks like we can get to prison_deref before RACCT is initialized for
 given prison.
 
 Please test the following:
 diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c
 index 1dc43ab..7ca1d72 100644
 --- a/sys/kern/kern_jail.c
 +++ b/sys/kern/kern_jail.c
 @@ -2604,7 +2604,8 @@ prison_deref(struct prison *pr, int flags)
                         cpuset_rel(pr->pr_cpuset);
                 osd_jail_exit(pr);
  #ifdef RACCT
 -               prison_racct_detach(pr);
 +               if (pr->pr_prison_racct != NULL)
 +                       prison_racct_detach(pr);
  #endif
                 free(pr, M_PRISON);
 
 
 -- 
 Mateusz Guzik <mjguzik gmail.com>