[Bug 255775] panic with ipfw turned on at boot time

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255775

--- Comment #10 from Michael Meiszl <michael at meiszl.de> ---
Just a note, in the file you have pointed out to patch, just a few lines below
on 834 you find
   error = ip_fragment(ip, &m, mtu, ifp->if_hwassist);
        if (error)
                goto bad;
        for (; m; m = m0) {
                m0 = m->m_nextpkt;
                m->m_nextpkt = 0; <<<<<<<!!!!
                if (error == 0) {
                        /* Record statistics for this interface address. */
                        if (ia != NULL) {
                                counter_u64_add(ia->ia_ifa.ifa_opackets, 1);
                                counter_u64_add(ia->ia_ifa.ifa_obytes,
                                    m->m_pkthdr.len);
                        }

although legal "m->m_nextpkt = 0;" does not look right. Better it should be
"m->m_nextpkt = NULL;" I think.

but 0 is surely not 0xdeadc0de...

-- 
You are receiving this mail because:
You are the assignee for the bug.