[Bug 226429] ipfw table add & hostname parsing

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226429

--- Comment #5 from commit-hook at freebsd.org ---
A commit references this bug:

Author: cem
Date: Thu Mar  8 17:23:19 UTC 2018
New revision: 330665
URL: https://svnweb.freebsd.org/changeset/base/330665

Log:
  ipfw(8): Fix endianness for Legacy and Ipv4 table hostname values

  The lookup_host() helper subroutine emits a struct in_addr value in network
  byte order via caller passed pointer.  However, the table value is expected
  to be stored in host byte order.  On little-endian machines, this produced a
  reversed endian table value for Legacy or IPv4 table types when the value
  was a hostname (instead of a plain IP address).

  Fix by using ntohl() on the output 32-bit address.

  While here, avoid some aliasing violations by storing the lookup_host()
  output in an intermediate object of the correct type.

  PR:           226429
  Reported by:  bugs.freebsd.org AT mx.zzux.com (also: Tested by)
  Security:     ipfw hostname table rules could potentially not act as admin
intended
  Sponsored by: Dell EMC Isilon

Changes:
  head/sbin/ipfw/tables.c

-- 
You are receiving this mail because:
You are the assignee for the bug.