kern/131817: commit references a PR

[dfilter service]

The following reply was made to PR kern/131817; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/131817: commit references a PR
Date: Mon,  4 Jul 2011 05:48:00 +0000 (UTC)

 Author: ae
 Date: Mon Jul  4 05:47:48 2011
 New Revision: 223753
 URL: http://svn.freebsd.org/changeset/base/223753
 
 Log:
   ARP code reuses mbuf from ARP request to make a reply, but it does not
   reset rcvif to NULL. Since rcvif is not NULL, ipfw(4) supposes that ARP
   replies were received on specified interface.
   Reset rcvif to NULL for ARP replies to fix this issue.
   
   PR:		kern/131817
   Reviewed by:	glebius
   MFC after:	1 month
 
 Modified:
   head/sys/netinet/if_ether.c
 
 Modified: head/sys/netinet/if_ether.c
 ==============================================================================
 --- head/sys/netinet/if_ether.c	Mon Jul  4 03:19:06 2011	(r223752)
 +++ head/sys/netinet/if_ether.c	Mon Jul  4 05:47:48 2011	(r223753)
 @@ -857,6 +857,7 @@ reply:
  	ah->ar_pro = htons(ETHERTYPE_IP); /* let's be sure! */
  	m->m_len = sizeof(*ah) + (2 * ah->ar_pln) + (2 * ah->ar_hln);   
  	m->m_pkthdr.len = m->m_len;   
 +	m->m_pkthdr.rcvif = NULL;
  	sa.sa_family = AF_ARP;
  	sa.sa_len = 2;
  	(*ifp->if_output)(ifp, m, &sa, NULL);
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"