Generating 'Fragment Needed but DF was Set' ICMP & Dummynet

[Max Laier]

On Monday 23 February 2004 17:25, Alexander Motin wrote:
> Here are my patches for this problem for FreeBSD 4.8 and 5.2.
> Review them please.

Looks good, though you might want to make sure to update statistics 
(ipstat.ips_cantfrag++). And maybe lose the type and code vars - you 
don't really use them:
-                       type = ICMP_UNREACH;
-                       code = ICMP_UNREACH_HOST;
-                       icmp_error(mcopy, type, code, 0, pkt->ifp);
+			icmp_error(mcopy, ICMP_UNREACH, ICMP_UNREACH_HOST,
+			    0, pkt->ifp);

Also note that this patch will require some work after the MT_TAG remove 
http://people.freebsd.org/~mlaier/mt_tag_remove.diff as pkt is freed with 
the mbuf. I'll keep it in mind.

-- 
Best regards,				| mlaier at freebsd.org
Max Laier				| ICQ #67774661
http://pf4freebsd.love2party.net/	| mlaier at EFnet