HEAD ip_fw2 ipsec b0rked

Hajimu UMEMOTO ume at mahoroba.org
Fri Nov 7 12:51:51 PST 2003


Hi,

>>>>> On Fri, 7 Nov 2003 12:26:12 +0000 (UTC)
>>>>> "Bjoern A. Zeeb" <bzeeb-lists at lists.zabbadoz.net> said:

bzeeb-lists> Either removing the f() entirely will make people notice it at compile
bzeeb-lists> time that s.th. is missing
bzeeb-lists> or running a find over the src tree will let you find these functions
bzeeb-lists> but giving a panic() isn't that nice ;-))

I've just committed to nuke obsoleted ipsec_gethist().
However, since opt_ipsec.h is not included, IPsec code is not compiled
in.  So, it cannot detect this case. ;)

bzeeb-lists> Perhaps Luigi or you culd review my patch and commit it so that both
bzeeb-lists> problems get fixed at ones because fixing one will not help making the
bzeeb-lists> other work in ip_fw2.c.

Since I dunno if it is intentional or not that it doesn't activate
IPsec code, I didn't change to include opt_ipsec.h.  I believe best
person is Luigi.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume at mahoroba.org  ume at bisd.hitachi.co.jp  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/


More information about the freebsd-ipfw mailing list