FWSPA

Christian Kandeler christian.kandeler at hob.de
Mon Feb 14 06:39:55 PST 2005


Hi,

in the ia64_init() function, the fpswa is initialized as follows:

    fpswa_interface = (FPSWA_INTERFACE*)IA64_PHYS_TO_RR7(bootinfo.bi_fpswa);

Shouldn't it be tested here whether bootinfo.bi_fpswa is NULL? It would make 
the follwing test in cpu_startup() much more meaningful:

	if (fpswa_interface == NULL)
		printf("Warning: no FPSWA package supplied\n");
	else
		printf("FPSWA Revision = 0x%lx, Entry = %p\n",
		    (long)fpswa_interface->Revision,
		    (void *)fpswa_interface->Fpswa);

As of now, this will always execute the else branch, because bootinfo.bi_fpswa 
was unconditionally or'ed with 7 << 61 and the result can therefore not be 
NULL. 
Or am I missing something?


Christian


More information about the freebsd-ia64 mailing list