maintainer-feedback requested: [Bug 239289] devel/hs-git-annex: git-annex-shell and git-remote-tor-annex symlinks don't point to git-annex, fail calling convention

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-haskell mailing
list <haskell at FreeBSD.org> for maintainer-feedback:
Bug 239289: devel/hs-git-annex: git-annex-shell and git-remote-tor-annex
symlinks don't point to git-annex, fail calling convention
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239289



--- Description ---
Hello,

git-annex runs git-annex-shell or git-remote-tor-annex functionality according
to the name it's called by
(http://source.git-annex.branchable.com/?p=source.git;a=blob;f=git-annex.hs;h=4
992f4c76ef00a2c6326cedeedefbec72ef7eb5e;hb=HEAD
for instance).

On current hs-git-annex installations, those commands are symlinks to a wrapper
script /usr/local/bin/git-annex, not the binary itself, which is located at
/usr/local/libexec/cabal/git-annex.

Running either will just result in running the non-qualified git-annex
functionality. The indirection defeats the calling convention.

I believe the wrapper script approach was introduced here:
https://svnweb.freebsd.org/ports?view=revision&sortby=log&sortdir=down&revision
=504093.

Not sure how to keep setting the environment variables without dedicated
wrappers for those commands calling links in /usr/local/libexec/cabal/ pointing
to git-annex.

Presumably this issue applies to any other program that relies on this kind of
calling convention.

Regards,