Including IB utils in install images

[Kyle Evans]

On Wed, Feb 3, 2021 at 12:29 PM Glen Barber <gjb at freebsd.org> wrote:
>
> On Wed, Feb 03, 2021 at 10:06:20AM -0800, Ravi Pokala wrote:
> > Hi folks,
> >
> > I'm using release/release.sh to create install images. We recently determined that we need to start including the InfiniBand utilities (contrib/ofed/infiniband-diags / usr.bin/ofed/infiniband-diags). I updated my release.conf to add 'WITH_OFED_EXTRA=1' to MAKE_FLAGS, and I confirmed that the utilities are being built. However, they are not subsequently copied to the distdir, or included in the resulting image. Well, technically, `ibstat' is, but per usr.bin/ofed/infiniband-diags/Makefile, it is not contingent on WITH_OFED_EXTRA / MK_OFED_EXTRA.
> >
> > Bug, or operator error?
> >
>
> You could set a local SRC_CONF (see release/release.conf.sample), but
> I *think* you also need to set WITH_OFED=1.  According to src.conf(5),
> it seems WITH_OFED_EXTRA is ignored unless WITH_OFED is explicitly set.
>

Ravi followed up privately here; the problem he was seeing is because
MAKE_FLAGS is only included in release.sh for building stuff.
WORLD_FLAGS gets closer to what he wants, but a local src.conf is
better as far as "touching build options" goes.

The caveat was that then they'd have to pair their release.conf with a
src.conf; I pointed out that release.conf is literally sourced in and
that's heavily baked in enough to release.sh that it cannot change. A
good solution for this kind of thing should be something along the
lines of:

srcconf=/path/whatever/maybe/tmpfile
cat <<EOF > $srcconf
WITH_OFED_EXTRA="YES"
EOF
...
SRC_CONF=$srcconf

Thanks,

Kyle Evans