Committing one ipfw(8) userland patch

Neel Chauhan neel at neelc.org
Sat Apr 11 03:47:15 UTC 2020


To be clear, src-ip/dst-ip is currently IPv4-only, while I know "me" is 
dual-stack.

If src-ip/dst-ip should stay IPv4-only, then the old patch is better in 
this case. If src-ip/dst-ip needs to be dual-stack, then the new patch 
is better.

-Neel

On 2020-04-10 20:37, Neel Chauhan wrote:
> Thank you all for your feedback.
> 
> Using the same Phabricator revision here: 
> https://reviews.freebsd.org/D24234
> 
> I have added the src-ip4/dst-ip4 and src-ipv4/dst-ipv4 specifiers and
> made src-ip/dst-ip dual-stack, to be consistent with me/me4/me6
> described in this thread.
> 
> Could you all please give your opinions on it?
> 
> -Neel
> 
> On 2020-04-10 04:10, Lev Serebryakov wrote:
>> On 10.04.2020 13:46, Andrey V. Elsukov wrote:
>> 
>>> On 07.04.2020 20:35, Rodney W. Grimes wrote:
>>>> But that is not what this review does.  I would be in support of
>>>> changing the "official" names to src-ip4/dst-ip4/src-ip6/dst-ip6
>>>> and making src-ip/dst-ip a backwards compatible alias.
>>> 
>>> I also think this idea sounds better.
>> 
>> +1
> _______________________________________________
> freebsd-hackers at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to 
> "freebsd-hackers-unsubscribe at freebsd.org"


More information about the freebsd-hackers mailing list