select call in devd

Eric van Gyzen eric at vangyzen.net
Wed Feb 14 15:01:55 UTC 2018


On 02/14/2018 01:13, Eitan Adler wrote:
> Hi all,
> 
> select(2) is declared with restrict for the pointers for fd. Can y'all
> confirm this is the correct fix?
> 
> It is only lightly tested (it seems to do its job on my machine)
> 
> Index: devd.cc
> ===================================================================
> --- devd.cc (revision 329192)
> +++ devd.cc (working copy)
> @@ -1021,7 +1021,7 @@ event_loop(void)
>   tv.tv_usec = 0;
>   FD_ZERO(&fds);
>   FD_SET(fd, &fds);
> - rv = select(fd + 1, &fds, &fds, &fds, &tv);
> + rv = select(fd + 1, &fds, NULL, NULL, &tv);
>   // No events -> we've processed all pending events
>   if (rv == 0) {
>   devdlog(LOG_DEBUG, "Calling daemon\n");

Looks good to me.

Eric


More information about the freebsd-hackers mailing list