Changes to pfctl to allow easier integration into a library

[Christian Mauderer]

Am 28.07.2016 um 16:03 schrieb Christian Mauderer:
> Hello,
> 
[...]
> 
> Would the attached patches be acceptable for integration into the
> FreeBSD sources?
> 
> I've generated the patches against the git commit b6ff7c02cf9 on
> https://github.com/freebsd/freebsd.git. Please tell me if another form
> would be better.
> 
> Kind regards,
> 
> Christian Mauderer
> 

Hello,

I've got one additional patch: I made most of the global variables
static. They are used only inside the scope of one single c file.
Despite that, they have not been static. If I try to link the source
file into a library every non-static variables pollutes my name space.

Can I improve anything to make the patches more acceptable?

Is the virtualisation that Bjoern mentioned necessary or was my
interpretation correct that this is only meant for kernel space code?

Kind Regards

Christian Mauderer
-- 
--------------------------------------------
embedded brains GmbH
Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.mauderer at embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-pfctl-Make-most-global-variables-static.patch
Type: text/x-patch
Size: 8260 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20160801/7dd5fa9a/attachment.bin>