[PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged
rozhuk.im at gmail.com
rozhuk.im at gmail.com
Wed Jan 14 02:26:00 UTC 2015
> >> Is this feature still useful with memtest.tests=0?
> > This feature is useful for everyone who has it set to 1, if they know
> > about it or not. So it's a very useful feature.
>
> Agreed.
>
> Comments on the patch:
>
> The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove
> PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too.
>
> The "total" line is mostly redundant with the later messages regarding
> "real memory" and "avail memory". I suggest removing it.
>
Maybe just write: checked XX megabytes of memory?
More information about the freebsd-hackers
mailing list