[PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged

Eric van Gyzen eric at vangyzen.net
Tue Jan 13 15:48:25 UTC 2015


On 01/13/2015 04:11, Lars Engels wrote:
> On Mon, Jan 12, 2015 at 12:27:18AM -0500, Allan Jude wrote:
>> Is this feature still useful with memtest.tests=0?
> This feature is useful for everyone who has it set to 1, if they know
> about it or not. So it's a very useful feature.

Agreed.

Comments on the patch:

The patch will divide by zero when PAGE_SIZE > 1 MiB.  Maybe remove
PAGES_PER_MB, and just use PAGES_PER_GB.  Make it const, too.

The "total" line is mostly redundant with the later messages regarding
"real memory" and "avail memory".  I suggest removing it.

Eric


More information about the freebsd-hackers mailing list