GBDE not protecting the user

[Michael W. Lucas]

On Sat, Oct 11, 2014 at 01:59:44PM -0400, Michael W. Lucas wrote:
> On Sat, Oct 11, 2014 at 11:17:23AM -0400, Allan Jude wrote:
> > Michael: please file a PR on this now that it is confirmed, and together
> > we can nag someone to fix it.
> 
> Fair enough.
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194304

Following up on my own bug report:

This seems to be a generic GBDE error message breakage. Here I change
key 0's passphrase and key file.

# gbde setkey da0p1 -n 0 -l da0p1.lock -k rat.jpg -L da0p1.lock-new
Enter passphrase:
Opened with key 0
Enter new passphrase:
Reenter new passphrase:

I now have a new lock file with a new passphrase. Let's try the old
key file and see what happens. It appears to work, except it doesn't.

# gbde attach da0p1 -l da0p1.lock -k rat.jpg
Enter passphrase:
# ls /dev/da0p1*
/dev/da0p1
# gbde detach da0p1
gbde: Detach of da0p1 failed: Geom not found: "da0p1.bde"

The new lock file and passphrase do work.

I would have expected the attach command to call me an idiot rather
than fail silently. An ignorant, uneducated, non-programmer look at
the code encourages my belief.

Bug report updated.

==ml

-- 
Michael W. Lucas  -  mwlucas at michaelwlucas.com, Twitter @mwlauthor 
http://www.MichaelWLucas.com/, http://blather.MichaelWLucas.com/