Expanding on NO_ROOT: Categorizing installed files

[Brooks Davis]

On Tue, Jul 15, 2014 at 02:10:24PM -0700, Sean Fagan wrote:
> Based on feedback primarily from Brooke Davis, an update.  The diffs are at http://earth.kithrup.com/~sef/auto-diffs.txt -- due to the size, I could not send them to the mailing list.
> 
> This primarily eliminates the environment passing; the cost of that is a lot more invasiveness.  (About 100k larger diffs, thus being unable to attach them.)

The vast majorify of the diff is make debugging garbage that looks like
it was committed by accident.  I won't provided any detailed review
of the current patch except to say that there are a lot of apparently
redundent instances of setting META_CATEGORY in Makefiles and still
quite a lot of instances of .EXPORTVAR: META_CATEGORY.

> I have not changed it from having a new "category=" to using "tag="; I looked at that, and don't think it's the best way to go, but am still looking.

Given that the current use of tags= is basically unconsumed, I still
don't understand why.

> I also want to go over it and ensure that NO_ROOT is a strict superset of LOG_META_INFO -- that is, -DNO_ROOT should set -DLOG_META_INFO, and thus most places where I check for either, I should only check for LOG_META_INFO.

That seems like a good direction.

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20140716/8a5d0c70/attachment.sig>