No subject

Mon Dec 8 13:39:22 UTC 2014

>From se at FreeBSD.org  Mon Dec  8 14:34:01 2014
Return-Path: <se at FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	StefanEsser.freebsd.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=7.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
	RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RDNS_NONE,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
X-Original-To: se at localhost
Received: from StefanEsser.freebsd.org (localhost [IPv6:::1])
	by StefanEsser.freebsd.org (Postfix) with ESMTP id 814C66FF
	for <se at localhost>; Mon,  8 Dec 2014 14:34:01 +0100 (CET)
Received: from sfwdallmx.t-online.de [194.25.134.46]
	by StefanEsser.freebsd.org with POP3 (fetchmail-6.3.26)
	for <se at localhost> (single-drop); Mon, 08 Dec 2014 14:34:01 +0100 (CET)
Received: from mailin58.aul.t-online.de ([172.20.27.247])
	by ehead603.aul.t-online.de (Dovecot) with LMTP id DS1GDYOmhVQ+LAAAPh7MgA;
	Mon, 08 Dec 2014 14:24:19 +0100
Received: from mx2.freebsd.org ([8.8.178.116]) by mailin58.aul.t-online.de
	with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted)
	esmtp id 1XxyIT-2JxvX60; Mon, 8 Dec 2014 14:24:17 +0100
Received: from hub.freebsd.org (hub.freebsd.org [8.8.178.136])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx2.freebsd.org (Postfix) with ESMTPS id 37D5B373A
	for <st_esser at t-online.de>; Mon,  8 Dec 2014 13:24:15 +0000 (UTC)
Received: by hub.freebsd.org (Postfix)
	id 35023C52; Mon,  8 Dec 2014 13:24:15 +0000 (UTC)
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 34387C50
	for <se at freebsd.org>; Mon,  8 Dec 2014 13:24:15 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id F2034146
	for <se at freebsd.org>; Mon,  8 Dec 2014 13:24:14 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5])
	by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id sB8DOEcg056293
	for <se at freebsd.org>; Mon, 8 Dec 2014 13:24:14 GMT
	(envelope-from root at phabric-backend.isc.freebsd.org)
Received: (from root at localhost)
	by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id sB8DOE39056292;
	Mon, 8 Dec 2014 13:24:14 GMT
	(envelope-from root)
Date: Mon, 8 Dec 2014 13:24:14 +0000
To: se at localhost.FreeBSD.org
From: =?utf-8?Q?se_=28Stefan_E=C3=9Fer=29?= <phabric-noreply at FreeBSD.org>
Subject: [Differential] [Updated, 639 lines] D1206: Add libxo support to pciconf
Message-ID: <75337b9bc584b5c3795df4e0b12641ad at localhost.localdomain>
X-Priority: 3
Thread-Topic: D1206: Add libxo support to pciconf
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-p2upbdzs3utlaxjqxjh7>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
In-Reply-To: <differential-rev-PHID-DREV-4l5pn3foclvp2vnpmdnu-req at FreeBSD.org>
References: <differential-rev-PHID-DREV-4l5pn3foclvp2vnpmdnu-req at FreeBSD.org>
Thread-Index: NmM1NGY4YmRhNzU1ODBkMDBiYjdjMTRhYWQ3IFSFpn4=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-updated>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-TOI-SPAM: u;0;2014-12-08T13:24:19Z
X-TOI-VIRUSSCAN: unchecked
X-TOI-MSGID: abfdb5d0-3bcc-4171-8a83-0d818bff93ab
X-Seen: false
X-ENVELOPE-TO: <st_esser at t-online.de>
X-UID: 182952
X-Keywords: NonJunk                                                  

se updated this revision to Diff 2680.
se added a comment.

Update after review by Phil Shafer and extend to cover errors and capabilities

Summary:

This version contains many fixes to issues pointed out by Phil and
a number of further enhancements:
- Use of XO lists and instances to structure the information
- Descriptive identifiers instead of abbreviations
- Addition of XO support to PCI/PCIe error reporting
- Addition of XO support to PCI/PCIe capability information printing

I do not have access to a PCI or PCI-Express Spec. with information on 
the capabilities and their specified names, but have only used publicly
available information to select XML/JSON labels. A pointer to a freely
available specification of PCI/PCIe capabilities (just the path that 
might help chose good names for data fields) would be highly appreciated.

Test Plan: 

This version of pciconf should generate 100% identical output, except 
when one of the structured XO formats is requested.

Please test with:
	pciconf -lbecv

I do not know whether the labels used for XML amd JSON output of PCI/PCIe
capabilities are well chosen. Several names are very long, but I wanted to 
avoid cryptic abbreviations. Suggestions for better or more correct names
are welcome.

I could not test output of Intel or AMD (Hyper Transport) specific 
capabilities (my Intel system uses SATA AHCI, but I do not see that in 
the reported capabilities; I do not have any FreeBSD systems on AMD 
hardware, currently).

I'm adding a few reviewers (jhb because he did the initial commit of cap.c
and kib because of the HT specific information that I cannot test). I hope 
you don't mind being selected as potential reviewers.

Reviewers: 

phil at juniper.net
hackers at freebsd.org
jhb at freebsd.org
kib at freebsd.org

Subscribers:

CHANGES SINCE LAST UPDATE
  https://reviews.freebsd.org/D1206?vs=2617&id=2680

REVISION DETAIL
  https://reviews.freebsd.org/D1206

AFFECTED FILES
  Makefile
  cap.c
  err.c
  pciconf.c

To: se
Cc: emaste