clang generated code sometimes confuses fbt

[Dimitry Andric]

On 2013-03-03 21:02, Dimitry Andric wrote:
> On 2013-03-03 17:36, Andriy Gapon wrote:
>> on 03/03/2013 17:45 Dimitry Andric said the following:
...
> So to fix this inconsistency, we could either change dw_read() to use
> the full name instead of the basename, or change sort_iidescs() to use
> the basename instead of the full name.
>
> The only upstream I have been able to find, Illumos, had the same code
> as FreeBSD for both of these functions, so it is likely they never
> noticed it before...
>
> My preference would be to remove the basename() call from dw_read(), as
> in the attached diff.  That seems to fix the problem here; the diff of
> ctfdump output before and after becomes:

Actually, that way of fixing breaks it for gcc, so it should really be
fixed in sort_iidescs() instead.  See attached diff; I verified it works
for both gcc-compiled and clang-compiled objects.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctfconvert-output-1.diff
Type: text/x-diff
Size: 763 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20130304/616bd141/attachment.diff>