please review, patch for lost camisr

Konstantin Belousov kostikbel at gmail.com
Wed Jun 19 05:02:55 UTC 2013


On Wed, May 29, 2013 at 10:16:45AM +0300, Konstantin Belousov wrote:
> Well, if you and I are right, the minimal patch should be
> 
> diff --git a/sys/kern/kern_intr.c b/sys/kern/kern_intr.c
> index 8d63c9b..7c21015 100644
> --- a/sys/kern/kern_intr.c
> +++ b/sys/kern/kern_intr.c
> @@ -1349,7 +1349,7 @@ ithread_loop(void *arg)
>  		 * we are running, it will set it_need to note that we
>  		 * should make another pass.
>  		 */
> -		while (ithd->it_need) {
> +		while (atomic_load_acq_int(&ithd->it_need)) {
>  			/*
>  			 * This might need a full read and write barrier
>  			 * to make sure that this write posts before any
> 

So, was it tested ? If yes, did the patch helped ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20130619/d7e8a5f3/attachment.sig>


More information about the freebsd-hackers mailing list