[RFQ] make witness panic an option

Attilio Rao attilio at freebsd.org
Thu Nov 15 18:01:20 UTC 2012


On 11/15/12, Adrian Chadd <adrian at freebsd.org> wrote:
> On 15 November 2012 09:56, Warner Losh <imp at bsdimp.com> wrote:
>
>>> Do you really think that an abusable mechanism will help here rather
>
>> It sounds like he's more worried about introducing LoRs into his wireless
>> code. They are harmless, for him, and he can fix them by reloading the
>> driver. They are only harmful if he loses a race.
>
> LOR's and lock assertions. Ie, I want to find out at run time that a
> lock wasnt' held at a certain position but continue soldiering on.
> That's how I've been finding out all of the races in net80211/ath, as
> there wasn't locking where there needed to be.

I think that your worries are focused more around the latter than the
former, which can be easilly shut down already today.

And frankly I will never be in favor of a patch that automatically
shutdowns lock assertion. Please patch your local code to do so but
don't add any generic/upstream/all-around mechanism for that.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the freebsd-hackers mailing list