dup3 syscall - atomic set O_CLOEXEC with dup2

Xin Li delphij at delphij.net
Fri Jan 20 23:35:37 UTC 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi, Eitan,

On 01/20/12 15:25, Eitan Adler wrote:
> I figure this isn't wanted?

Since this is modeled after Linux's dup3() system call, would you
please also add a compat entry for it?  By the way:

> On Thu, Jan 12, 2012 at 10:07 PM, Eitan Adler
> <lists at eitanadler.com> wrote:
>> Okay - here is version 2 (compile and run tested) Index:
>> sys/kern/syscalls.master 
>> ===================================================================
>>
>> 
- --- sys/kern/syscalls.master    (revision 229830)
>> +++ sys/kern/syscalls.master    (working copy) @@ -951,5 +951,6
>> @@ off_t offset, off_t len); } 531    AUE_NULL        STD     {
>> int posix_fadvise(int fd, off_t offset, \ off_t len, int advice);
>> } +532    AUE_NULL        STD     { int dup3(u_int from, u_int
>> to, int flags); }

I think we want audit here?

>> ; Please copy any additions and changes to the following
>> compatability tables: ; sys/compat/freebsd32/syscalls.master 
>> Index: sys/compat/freebsd32/syscalls.master 
>> ===================================================================
>>
>> 
- --- sys/compat/freebsd32/syscalls.master        (revision 229830)
>> +++ sys/compat/freebsd32/syscalls.master        (working copy) @@
>> -997,3 +997,4 @@ uint32_t offset1, uint32_t offset2,\ uint32_t
>> len1, uint32_t len2, \ int advice); } +532    AUE_NULL        STD
>> { int dup3(u_int from, u_int to, int flags); }

Ditto...

Cheers,
- -- 
Xin LI <delphij at delphij.net>	https://www.delphij.net/
FreeBSD - The Power to Serve!		Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8Z+kYACgkQOfuToMruuMBe/ACfQ9aR5OfPZTS3q/AVNheUDliQ
nIYAnjp/5qblxlOLDAvB6AferlpFQjOa
=lTV+
-----END PGP SIGNATURE-----


More information about the freebsd-hackers mailing list